ForegroundProcessDialog: Modernise/Gtk4 preparation#882
Merged
Conversation
lenemter
previously requested changes
Jul 31, 2025
danirabbit
requested changes
Aug 1, 2025
| * Boston, MA 02110-1301 USA | ||
| */ | ||
| * SPDX-License-Identifier: LGPL-3.0-or-later | ||
| * SPDX-FileCopyrightText: 2011-2025 elementary, Inc. (https://elementary.io) |
Member
There was a problem hiding this comment.
Since there's no code changes here, we shouldn't bump the copyright date
Collaborator
Author
There was a problem hiding this comment.
OK, so you are happy there is are no code changes that need be/can be done before the port?
Member
There was a problem hiding this comment.
I mean the class is only 30 lines long, I can't see anything you could change here no 🤷♀️ I'm not sure I would really call this PR a GTK4 prep though, so much as just using the SPDX header
danirabbit
approved these changes
Aug 4, 2025
jeremypw
dismissed
lenemter’s stale review
Requested changes made and approved by @danirabbit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any more preparation needed?
Keeping as draft until pending release goes out.